Skip to content

feat[UI]: update generated.ts#1336

Merged
benjamin-747 merged 1 commit into
gitmono-dev:mainfrom
benjamin-747:main
Aug 14, 2025
Merged

feat[UI]: update generated.ts#1336
benjamin-747 merged 1 commit into
gitmono-dev:mainfrom
benjamin-747:main

Conversation

@benjamin-747

Copy link
Copy Markdown
Collaborator

No description provided.

@benjamin-747
benjamin-747 requested a review from genedna August 14, 2025 09:02
@vercel

vercel Bot commented Aug 14, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Project Deployment Preview Comments Updated (UTC)
mega Ready Preview Comment Aug 14, 2025 9:03am

@genedna
genedna requested a review from Copilot August 14, 2025 09:03

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the generated TypeScript types to support pagination for merge request file changes. It introduces a new POST endpoint for paginated file change retrieval alongside the existing GET endpoint.

Key changes:

  • Adds pagination support for merge request file changes with new types and endpoint
  • Refactors content field from string to DiffItem array for better type safety
  • Updates API documentation to clarify endpoint purposes

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
moon/packages/types/generated.ts Adds new pagination types, refactors content structure, and implements POST endpoint for paginated file changes
mono/src/api/mr/mr_router.rs Updates request body type from PageParams to PageParams

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

export type CommonResultFilesChangedList = {
data?: {
content: string
content: DiffItem[]

Copilot AI Aug 14, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaking change modifies the content field from string to DiffItem[] without maintaining backward compatibility. Consider implementing a versioned API or providing migration guidance for existing consumers.

Suggested change
content: DiffItem[]
content: string | DiffItem[]

Copilot uses AI. Check for mistakes.

export type FilesChangedList = {
content: string
content: DiffItem[]

Copilot AI Aug 14, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to the CommonResultFilesChangedList type, this breaking change to the content field could impact existing API consumers. Ensure proper migration strategy is in place.

Copilot uses AI. Check for mistakes.
@benjamin-747

Copy link
Copy Markdown
Collaborator Author

需要UI 侧进行修改,先合并

@benjamin-747
benjamin-747 added this pull request to the merge queue Aug 14, 2025
Merged via the queue into gitmono-dev:main with commit de12583 Aug 14, 2025
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants